Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update service mesh integration docs for transparent proxy #20251

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 28, 2024

Update the service mesh integration docs to explain how Consul needs to be configured for transparent proxy. Update the walkthrough to assume that transparent_proxy mode is the best approach, and move the manually-configured upstreams to a separate section for users who don't want to use Consul DNS.

Ref: #20175
Ref: #20241

@tgross tgross mentioned this pull request Mar 28, 2024
10 tasks
@tgross tgross added the theme/consul/connect Consul Connect integration label Mar 28, 2024
@tgross tgross added this to the 1.8.0 milestone Mar 28, 2024
@tgross tgross added the theme/docs Documentation issues and enhancements label Mar 28, 2024
@tgross tgross marked this pull request as ready for review March 28, 2024 16:03
Update the service mesh integration docs to explain how Consul needs to be
configured for transparent proxy. Update the walkthrough to assume that
`transparent_proxy` mode is the best approach, and move the manually-configured
`upstreams` to a separate section for users who don't want to use Consul DNS.

Ref: #20175
Ref: #20241
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tgross tgross merged commit 9497205 into f-tproxy Apr 3, 2024
6 checks passed
@tgross tgross deleted the f-tproxy-integration-docs branch April 3, 2024 20:22
tgross added a commit that referenced this pull request Apr 4, 2024
)

Update the service mesh integration docs to explain how Consul needs to be
configured for transparent proxy. Update the walkthrough to assume that
`transparent_proxy` mode is the best approach, and move the manually-configured
`upstreams` to a separate section for users who don't want to use Consul DNS.

Ref: #20175
Ref: #20241
philrenaud pushed a commit that referenced this pull request Apr 18, 2024
)

Update the service mesh integration docs to explain how Consul needs to be
configured for transparent proxy. Update the walkthrough to assume that
`transparent_proxy` mode is the best approach, and move the manually-configured
`upstreams` to a separate section for users who don't want to use Consul DNS.

Ref: #20175
Ref: #20241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/consul/connect Consul Connect integration theme/docs Documentation issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants